| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | amit(dot)kapila16(at)gmail(dot)com |
| Cc: | shveta(dot)malik(at)gmail(dot)com, euler(at)eulerto(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: About a recently-added message |
| Date: | 2024-02-22 05:40:05 |
| Message-ID: | 20240222.144005.900862999527013624.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Thu, 22 Feb 2024 10:51:07 +0530, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote in
> > Do you think some additional tests for the rest of the messages are
> > worth the trouble?
> >
>
> We have discussed this during development and didn't find it worth
> adding tests for all misconfigured parameters. However, in the next
> patch where we are planning to add a slot sync worker that will
> automatically sync slots, we are adding a test for one more parameter.
> I am not against adding tests for all the parameters but it didn't
> appeal to add more test cycles for this.
Thanks for the explanation. I'm fine with that.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2024-02-22 06:19:36 | Re: Add lookup table for replication slot invalidation causes |
| Previous Message | Amit Kapila | 2024-02-22 05:21:07 | Re: About a recently-added message |