Re: Re[2]: [PATCH] allow pg_current_logfile() execution under pg_monitor role

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Pavlo Golub <pavlo(dot)golub(at)cybertec(dot)at>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re[2]: [PATCH] allow pg_current_logfile() execution under pg_monitor role
Date: 2024-02-14 18:49:56
Message-ID: 20240214184956.GA372883@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Feb 14, 2024 at 01:45:31PM -0500, Tom Lane wrote:
> "Pavlo Golub" <pavlo(dot)golub(at)cybertec(dot)at> writes:
>> Oh, thanks! I forgot, indeed, to update docs and catalog version! My
>> bad!
>
> Docs, yes, but don't include catversion bumps in submitted patches.
> They'll just lead to merge problems when somebody else changes the
> current catversion. We rely on the committer to remember to do this
> (which is an imperfect system, but...)

+1, I only included it in the patch I posted so that I didn't forget it...

--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2024-02-14 18:51:30 Re: Fix a typo in pg_rotate_logfile
Previous Message Pavlo Golub 2024-02-14 18:47:07 Re: Re[2]: [PATCH] allow pg_current_logfile() execution under pg_monitor role