| From: | Sutou Kouhei <kou(at)clear-code(dot)com> |
|---|---|
| To: | michael(at)paquier(dot)xyz |
| Cc: | andres(at)anarazel(dot)de, tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)postgresql(dot)org, ishii(at)sraoss(dot)co(dot)jp |
| Subject: | Re: confusing / inefficient "need_transcoding" handling in copy |
| Date: | 2024-02-14 02:46:08 |
| Message-ID: | 20240214.114608.2091541942684063981.kou@clear-code.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
In <ZcvlgMEjt3qY8eiL(at)paquier(dot)xyz>
"Re: confusing / inefficient "need_transcoding" handling in copy" on Wed, 14 Feb 2024 06:56:16 +0900,
Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> We have a couple of non-ASCII characters in the tests, but I suspect
> that this one will not be digested correctly everywhere, even if
> EUC_JP should be OK to use for the check. How about writing an
> arbitrary sequence of bytes into a temporary file that gets used for
> the COPY FROM instead? See for example how we do that with
> abs_builddir in copy.sql.
It makes sense. How about the attached patch?
Thanks,
--
kou
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Add-a-test-for-invalid-encoding-for-COPY-FROM.patch | text/x-patch | 2.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2024-02-14 02:55:08 | Re: Improve WALRead() to suck data directly from WAL buffers when possible |
| Previous Message | Amit Kapila | 2024-02-14 02:39:33 | Re: Synchronizing slots from primary to standby |