From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Printing backtrace of postgres processes |
Date: | 2024-02-09 08:48:36 |
Message-ID: | 202402090848.j6evnpunbehe@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2024-Feb-09, Michael Paquier wrote:
> Anyway, I've been digging around the signal-safety of backtrace(3)
> (even looking a bit at some GCC code, brrr), and I am under the
> impression that backtrace() is just by nature not safe and also
> dangerous in signal handlers. One example of issue I've found:
> https://github.com/gperftools/gperftools/issues/838
>
> This looks like enough ground to me to reject the patch.
Hmm, but the backtrace() manpage says
• backtrace() and backtrace_symbols_fd() don't call malloc() explic‐
itly, but they are part of libgcc, which gets loaded dynamically
when first used. Dynamic loading usually triggers a call to mal‐
loc(3). If you need certain calls to these two functions to not
allocate memory (in signal handlers, for example), you need to make
sure libgcc is loaded beforehand.
and the patch ensures that libgcc is loaded by calling a dummy
backtrace() at the start of the process.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"All rings of power are equal,
But some rings of power are more equal than others."
(George Orwell's The Lord of the Rings)
From | Date | Subject | |
---|---|---|---|
Next Message | Ashutosh Bapat | 2024-02-09 08:57:26 | Re: Printing backtrace of postgres processes |
Previous Message | Julien Rouhaud | 2024-02-09 08:37:23 | Re: Small fix on query_id_enabled |