| From: | Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | champion(dot)p(at)gmail(dot)com, er(at)xs4all(dot)nl, vik(at)postgresfriends(dot)org, chen(at)sraoss(dot)co(dot)jp |
| Subject: | Re: Row pattern recognition |
| Date: | 2024-01-22 10:26:18 |
| Message-ID: | 20240122.192618.1615493379143042775.t-ishii@sranhm.sra.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Attached is the v13 patch. Below are the summary of the changes from
previous version (besides rebase).
0001-Row-pattern-recognition-patch-for-raw-parser.patch
- Fix raw paser per Peter Eisentraut's review. Remove the new node
types and use existing ones. Also remove %nonassoc so that
MEASURES etc. have the same precedence as IDENT etc.
Peter's comment:
> It is usually not the style to add an entry for every node type to the
> %union. Otherwise, we'd have hundreds of entries in there.
> It was recently discussed that these %nonassoc should ideally all have
> the same precedence. Did you consider that here?
0002-Row-pattern-recognition-patch-parse-analysis.patch
- Fix transformRPR so that SKIP variable name in the AFTER MATCH SKIP
TO clause is tracked. This is added by Ningwei Chen.
0003-Row-pattern-recognition-patch-rewriter.patch
This is a new patch for rewriter. Contributed by Ningwei Chen.
Chen's comment:
> After applying the v12-patches, I noticed an issue that
> the rpr related parts in window clauses were not displayed in the
> view definitions (the definition column of pg_views).
0004-Row-pattern-recognition-patch-planner.patch
- same as before (previously it was 0003-Row-pattern-recognition-patch-planner.patch)
0005-Row-pattern-recognition-patch-executor.patch
- same as before (previously it was 0004-Row-pattern-recognition-patch-executor.patch)
0006-Row-pattern-recognition-patch-docs.patch
- Same as before. (previously it was 0005-Row-pattern-recognition-patch-docs.patch)
0007-Row-pattern-recognition-patch-tests.patch
- Same as before. (previously it was 0006-Row-pattern-recognition-patch-tests.patch)
0008-Allow-to-print-raw-parse-tree.patch
- Same as before. (previously it was 0007-Allow-to-print-raw-parse-tree.patch).
Note that patch is not intended to be incorporated into main
tree. This is just for debugging purpose. With this patch, raw parse
tree is printed if debug_print_parse is enabled.
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
| Attachment | Content-Type | Size |
|---|---|---|
| v13-0001-Row-pattern-recognition-patch-for-raw-parser.patch | text/x-patch | 19.5 KB |
| v13-0002-Row-pattern-recognition-patch-parse-analysis.patch | text/x-patch | 11.3 KB |
| v13-0003-Row-pattern-recognition-patch-rewriter.patch | text/x-patch | 4.0 KB |
| v13-0004-Row-pattern-recognition-patch-planner.patch | text/x-patch | 6.6 KB |
| v13-0005-Row-pattern-recognition-patch-executor.patch | text/x-patch | 51.1 KB |
| v13-0006-Row-pattern-recognition-patch-docs.patch | text/x-patch | 9.6 KB |
| v13-0007-Row-pattern-recognition-patch-tests.patch | text/x-patch | 46.2 KB |
| v13-0008-Allow-to-print-raw-parse-tree.patch | text/x-patch | 750 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseev | 2024-01-22 10:38:23 | Re: XLog size reductions: smaller XLRec block header for PG17 |
| Previous Message | Peter Eisentraut | 2024-01-22 10:18:31 | Re: Make documentation builds reproducible |