Re: POC PATCH: copy from ... exceptions to: (was Re: VLDB Features)

At Wed, 17 Jan 2024 14:38:54 +0900, torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> wrote in
> Hi,
>
> Thanks for applying!
>
> > + errmsg_plural("%zd row were skipped due to data type
> > incompatibility",
>
> Sorry, I just noticed it, but 'were' should be 'was' here?
>
> >> BTW I'm thinking we should add a column to pg_stat_progress_copy that
> >> counts soft errors. I'll suggest this in another thread.
> > Please do!
>
> I've started it here:
>
> https://www.postgresql.org/message-id/d12fd8c99adcae2744212cb23feff6ed@oss.nttdata.com

Switching topics, this commit (9e2d870119) adds the following help message:

> "COPY { %s [ ( %s [, ...] ) ] | ( %s ) }\n"
> " TO { '%s' | PROGRAM '%s' | STDOUT }\n"
> ...
> " SAVE_ERROR_TO '%s'\n"
> ...
> _("location"),

On the other hand, SAVE_ERROR_TO takes 'error' or 'none', which
indicate "immediately error out" and 'just ignore the failure'
respectively, but these options hardly seem to denote a 'location',
and appear more like an 'action'. I somewhat suspect that this
parameter name intially conceived with the assupmtion that it would
take file names or similar parameters. I'm not sure if others will
agree, but I think the parameter name might not be the best
choice. For instance, considering the addition of the third value
'log', something like on_error_action (error, ignore, log) would be
more intuitively understandable. What do you think?

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center