| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Abhijit Menon-Sen <ams(at)toroid(dot)org> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: introduce dynamic shared memory registry |
| Date: | 2024-01-13 21:41:24 |
| Message-ID: | 20240113214124.GA4162765@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 12, 2024 at 01:45:55PM -0600, Nathan Bossart wrote:
> On Fri, Jan 12, 2024 at 11:13:46PM +0530, Abhijit Menon-Sen wrote:
>> At 2024-01-12 11:21:52 -0600, nathandbossart(at)gmail(dot)com wrote:
>>> + Each backend sould obtain a pointer to the reserved shared memory by
>>
>> sould → should
>
> D'oh. Thanks.
>
>>> + Add-ins can reserve LWLocks on server startup. Like with shared memory,
>>
>> (Would "As with shared memory" read better? Maybe, but then again maybe
>> it should be left alone because you also write "Unlike with" elsewhere.)
>
> I think "As with shared memory..." sounds better here.
Here is a new version of the patch set with these changes.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-reorganize-shared-memory-and-lwlocks-documentatio.patch | text/x-diff | 9.3 KB |
| v7-0002-add-dsm-registry.patch | text/x-diff | 22.5 KB |
| v7-0003-use-dsm-registry-for-pg_prewarm.patch | text/x-diff | 3.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2024-01-13 22:38:00 | Re: Postgres and --config-file option |
| Previous Message | Ranier Vilela | 2024-01-13 21:38:13 | Fix a possible socket leak at Windows (src/backend/port/win32/socket.c) |