| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: introduce dynamic shared memory registry |
| Date: | 2024-01-06 16:35:16 |
| Message-ID: | 20240106163516.GB2435448@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jan 06, 2024 at 07:34:15PM +0530, Bharath Rupireddy wrote:
> 1. Update all the copyright to the new year. A run of
> src/tools/copyright.pl on the source tree will take care of it at some
> point, but still it's good if we can update while we are here.
Done.
> 2. Typo: missing "an" before "already-attached".
> + /* Return address of already-attached DSM registry entry. */
Done.
> 3. Use NAMEDATALEN instead of 64?
> + char key[64];
I kept this the same, as I didn't see any need to tie the key size to
NAMEDATALEN.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-add-dsm-registry.patch | text/x-diff | 19.2 KB |
| v5-0002-use-dsm-registry-for-pg_prewarm.patch | text/x-diff | 3.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhang Mingli | 2024-01-06 16:48:17 | Re: weird GROUPING SETS and ORDER BY behaviour |
| Previous Message | Peter Geoghegan | 2024-01-06 16:34:25 | Re: Emit fewer vacuum records by reaping removable tuples during pruning |