| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: verify predefined LWLocks have entries in wait_event_names.txt |
| Date: | 2024-01-06 16:18:52 |
| Message-ID: | 20240106161852.GA2435448@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jan 06, 2024 at 09:03:52AM +0000, Bertrand Drouvot wrote:
> Sorry, I missed this in my first review, but instead of:
>
> - input: files('../../backend/storage/lmgr/lwlocknames.txt'),
> + input: [files('../../backend/storage/lmgr/lwlocknames.txt'), files('../../backend/utils/activity/wait_event_names.txt')],
>
> what about?
>
> input: files(
> '../../backend/storage/lmgr/lwlocknames.txt',
> '../../backend/utils/activity/wait_event_names.txt',
> ),
>
> It's done that way in doc/src/sgml/meson.build for example.
I fixed this in v4.
> Except for the above, the patch looks good to me.
Thanks for reviewing!
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-verify-lists-of-predefined-LWLocks-in-lwlocknames.patch | text/x-diff | 6.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2024-01-06 16:22:04 | Re: weird GROUPING SETS and ORDER BY behaviour |
| Previous Message | Peter Geoghegan | 2024-01-06 16:03:03 | Re: Emit fewer vacuum records by reaping removable tuples during pruning |