Re: BUG #18264: Table has type text, but query expects integer.attribute 1 of type record has wrong type

I am impressed with how quickly you addressed the issue. I tested queries myself on latest builds and issue is resolved. Also all errors we were getting in more complex queries are gone.

Thank you for your work.
Vojtěch
 
______________________________________________________________
> Od: "David Rowley" <dgrowleyml(at)gmail(dot)com>
> Komu: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
> Datum: 04.01.2024 08:43
> Předmět: Re: BUG #18264: Table has type text, but query expects integer.attribute 1 of type record has wrong type
>
> CC: <pgsql-bugs(at)lists(dot)postgresql(dot)org>
On Sun, 31 Dec 2023 at 16:24, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> It looks like the problem is in ExecEvalPreOrderedDistinctMulti(). It
> overwrites the tmpcontext's slots but fails to properly restore the
> originals again.

I pushed a slightly revised version of this.  I ended up adding a bool
isdistinct local variable so I didn't have to reset the slots in two
places.  It kinda makes it easier to see what the true and false
means, so that might have been a good change regardless of the bug.

Thanks for reporting this Vojtěch and for the reproducer script.

David