| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: verify predefined LWLocks have entries in wait_event_names.txt |
| Date: | 2024-01-05 06:14:15 |
| Message-ID: | 20240105061415.GA2167264@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 03, 2024 at 11:34:25AM +0900, Michael Paquier wrote:
> On Tue, Jan 02, 2024 at 11:31:20AM -0600, Nathan Bossart wrote:
>> +# Find the location of lwlocknames.h.
>> +my $include_dir = $node->config_data('--includedir');
>> +my $lwlocknames_file = "$include_dir/server/storage/lwlocknames.h";
>
> I am afraid that this is incorrect because an installation could
> decide to install server-side headers in a different path than
> $include/server/. Using --includedir-server would be the correct
> answer, appending "storage/lwlocknames.h" to the path retrieved from
> pg_config.
Ah, good to know, thanks.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shlok Kyal | 2024-01-05 06:49:14 | Re: speed up a logical replica setup |
| Previous Message | Nathan Bossart | 2024-01-05 06:11:44 | Re: verify predefined LWLocks have entries in wait_event_names.txt |