Should "CRC" be in uppercase?

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Should "CRC" be in uppercase?
Date: 2023-12-25 05:51:24
Message-ID: 20231225.145124.1745560266993421173.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

A new function check_control_file() in pg_combinebackup.c has the
following message.

> pg_fatal("%s: crc is incorrect", controlpath);

I think "crc" should be in all uppercase in general and a brief
grep'ing told me that it is almost always or consistently used in
uppercase in our tree.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
upper_case_crc.diff text/x-patch 622 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-12-25 06:20:58 Re: Show WAL write and fsync stats in pg_stat_io
Previous Message Kyotaro Horiguchi 2023-12-25 05:39:16 Re: pg_basebackup has an accidentaly separated help message