Re: Unchecked strdup leading to segfault in pg_dump

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Tristan Partin <tristan(at)neon(dot)tech>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Unchecked strdup leading to segfault in pg_dump
Date: 2023-12-20 16:20:26
Message-ID: 20231220162026.GD833819@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Dec 20, 2023 at 09:39:55AM -0600, Tristan Partin wrote:
> On Wed Dec 20, 2023 at 8:52 AM CST, Daniel Gustafsson wrote:
>> While looking at something else I noticed that pg_dump performs strdup without
>> checking the returned pointer, which will segfault in hasSuffix() in case of
>> OOM. The attached, which should be backpatched to 16, changes to using
>> pg_strdup instead which handles it.
>
> Looks good to me.

+1

--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2023-12-20 16:32:22 Re: Remove MSVC scripts from the tree
Previous Message Nathan Bossart 2023-12-20 16:18:36 Re: introduce dynamic shared memory registry