Re: UBSan pointer overflow in xlogreader.c

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: UBSan pointer overflow in xlogreader.c
Date: 2023-12-05 21:01:41
Message-ID: 20231205210141.GA2762421@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Dec 05, 2023 at 03:48:33PM -0500, Robert Haas wrote:
> The patch LGTM, too. Thanks for investigating and writing the code.
> The part about how the reserved kernel memory prevents the bug from
> appearing on 32-bit systems but not 64-bit systems running in 32-bit
> mode is pretty interesting -- I don't want to think about how long it
> would have taken me to figure that out.

+1

--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joe Conway 2023-12-05 21:02:06 Re: Emitting JSON to file using COPY TO
Previous Message Andrew Dunstan 2023-12-05 20:55:53 Re: Emitting JSON to file using COPY TO