Re: BUG #17948: libpq seems to misbehave in a pipelining corner case

On 2023-Aug-05, Трофимов Иван wrote:

> We've managed to reproduce client <-> server de-synchronization triggered
> by this, which we are seeing in production.
> Libpq considers '< 2TDCEZ' a sufficient response to '> BDESS', when
> according to specification one more 'Z' is expected.
>  
> A bit more context and a MRE:
> https://github.com/itrofimow/libpq_protocol_desync

Does this patch fix the problems? I think the sync loss is because
we're consuming elements from the command queue even when we shouldn't,
because we don't know for an ERROR whether we should do so or not. What
this patch does is a bit of a hack, I think, but it does solve your test
case (and it doesn't break anything else in the tree) AFAICS. I may
have to play some more with it before gaining confidence, though.

Thanks

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Hay dos momentos en la vida de un hombre en los que no debería
especular: cuando puede permitírselo y cuando no puede" (Mark Twain)