Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*

From: Andres Freund <andres(at)anarazel(dot)de>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*
Date: 2023-11-29 16:19:16
Message-ID: 20231129161916.r7fsjqqirtz7r3ob@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Hi,

On 2023-11-29 10:05:26 -0500, Andrew Dunstan wrote:
> On 2023-11-29 We 08:49, Tom Lane wrote:
> > Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> > > On 2023-11-28 Tu 21:28, Andres Freund wrote:
> > > > I don't really understand why meson compile complains in this case. I assume
> > > > you don't want to disambiguate as suggested, by building html:alias instead?
> > > I've done that as a temporary fix to get crake out of the hole, but it's
> > > pretty ugly, and I don't want to do it in a release if at all possible.
> > Our documentation says specifically that "ninja html" will build the
> > HTML format. I would expect that to work by analogy with the "make"
> > target; having to spell it differently seems like clearly a bug.
> >
> >
>
>
> "ninja html" does in fact work. What's not working is "meson compile html".
> And it looks like the reason I used that in the buildfarm code is that ninja
> doesn't know about other targets like "postgres-US.pdf".

It does:

ninja help|grep pdf
doc/src/sgml/postgres-A4.pdf Build documentation in PDF format, with A4 pages
doc/src/sgml/postgres-US.pdf Build documentation in PDF format, with US letter pages

"ninja doc/src/sgml/postgres-US.pdf" works and has worked since day one.

FWIW, you can continue to use meson compile, you just need to disambiguate the
target name:
meson compile html:alias

Which isn't particularly pretty, but does work.

Greetings,

Andres Freund

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2023-11-29 18:36:19 Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*
Previous Message Andrew Dunstan 2023-11-29 15:05:26 Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*

Browse pgsql-hackers by date

  From Date Subject
Next Message John Naylor 2023-11-29 16:26:21 Re: Change GUC hashtable to use simplehash?
Previous Message Pavel Stehule 2023-11-29 15:50:42 Re: proposal: possibility to read dumped table's name from file