| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Cc: | Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Richard Guo <guofenglinux(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Assert failure on 'list_member_ptr(rel->joininfo, restrictinfo)' |
| Date: | 2023-11-27 18:07:05 |
| Message-ID: | 20231127180705.svzrlahdmqvosqfz@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2023-11-27 11:29:48 +0530, Ashutosh Bapat wrote:
> How do we ensure that we are not making unnecessary copies of Bitmapsets?
We don't - but that's not specific to this patch. Bitmapsets typically aren't
very large, I doubt that it's a significant proportion of the memory
usage. Adding refcounts or such would likely add more overhead than it'd save,
both in time and memory.
I am a bit worried about the maintainability of remove_rel_from_query() et
al. Is there any infrastructure for detecting that some PlannerInfo field that
needs updating wasn't updated? There's not even a note in PlannerInfo that
documents that that needs to happen.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2023-11-27 18:15:55 | Re: logical decoding and replication of sequences, take 2 |
| Previous Message | Nazir Bilal Yavuz | 2023-11-27 18:05:42 | SSL tests fail on OpenSSL v3.2.0 |