Re: Explicitly skip TAP tests under Meson if disabled

From: Andres Freund <andres(at)anarazel(dot)de>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Explicitly skip TAP tests under Meson if disabled
Date: 2023-11-06 22:03:08
Message-ID: 20231106220308.vo3jiwxhaf7wvmti@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2023-11-06 17:46:23 +0100, Peter Eisentraut wrote:
> On 04.11.23 01:51, Andres Freund wrote:
> > I'd just use a single test() invocation here, and add an argument to testwrap
> > indicating that it should print out the skipped message. That way we a) don't
> > need two test() invocations, b) could still see the test name etc in the test
> > invocation.
>
> Is testwrap only meant to be used with the tap protocol mode of meson's
> test()? Otherwise, this skip option would have produce different output for
> different protocols.

Since Daniel added tap support to pg_regress it's only used with tap. If we
add something else, we can add a format parameter?

Greetings,

Andres Freund

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jonathan S. Katz 2023-11-06 22:04:25 2023-11-09 release announcement draft
Previous Message David Steele 2023-11-06 21:39:02 Re: Add recovery to pg_control and remove backup_label