| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | kuroda(dot)hayato(at)fujitsu(dot)com |
| Cc: | shlok(dot)kyal(dot)oss(at)gmail(dot)com, michael(at)paquier(dot)xyz, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pg_ctl start may return 0 even if the postmaster has been already started on Windows |
| Date: | 2023-10-24 08:25:36 |
| Message-ID: | 20231024.172536.511643991820398116.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Tue, 24 Oct 2023 07:37:22 +0000, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> wrote in
> Dear Horiguchi-san,
>
> Thanks for updates! I was quite not sure the Windows env, but I can post comments.
> (We need reviews by windows-friendly developers...)
Indeed, I haven't managed to successfully build using Meson on
Windows...
> Formatting of messages for write_stderr() seem different from others. In v3,
> I slightly modified for readability like below. I wanted to let you know just in case
> because you did not say anything about these changes...
Ah. Sorry, I was lazy about the messages because I didn't regard this
to be at that stage yet.
In the attached, fixed the existing two messages, and adjusted one
message to display an error code, all in the consistent format.
Thanks!
--
Kyotaro Horiguchi
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Disable-autoruns-for-cmd.exe-on-Windows.patch | text/x-patch | 1.3 KB |
| v5-0002-Improve-pg_ctl-postmaster-process-check-on-Window.patch | text/x-patch | 5.1 KB |
| v5-0003-Remove-short-sleep-from-001_start_stop.pl.patch | text/x-patch | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2023-10-24 08:32:58 | Re: Replace references to malloc() in libpq documentation with generic language |
| Previous Message | Andrei Zubkov | 2023-10-24 07:58:48 | Re: [PATCH] Tracking statements entry timestamp in pg_stat_statements |