| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru> |
| Subject: | Re: Is it worth adding Assert(false) for unknown paths in print_path()? |
| Date: | 2023-09-28 13:41:06 |
| Message-ID: | 202309281341.o6n3nglxq2rx@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2023-Sep-29, David Rowley wrote:
> In [1] Andrey highlighted that I'd forgotten to add print_path()
> handling for TidRangePaths in bb437f995.
>
> I know the OPTIMIZER_DEBUG code isn't exactly well used. I never
> personally use it and I work quite a bit in the planner, however, if
> we're keeping it, I thought maybe we might get the memo of missing
> paths a bit sooner if we add an Assert(false) in the default cases.
>
> Is the attached worthwhile?
Hmm, if we had a buildfarm animal with OPTIMIZER_DEBUG turned on, then I
agree it would catch the omission quickly.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"¿Cómo puedes confiar en algo que pagas y que no ves,
y no confiar en algo que te dan y te lo muestran?" (Germán Poo)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2023-09-28 13:50:43 | pg_resetwal: Corrections around -c option |
| Previous Message | Daniel Gustafsson | 2023-09-28 13:39:41 | Re: Clarify where the severity level is defined |