Re: pg_upgrade --check fails to warn about abstime

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Tristan Partin <tristan(at)neon(dot)tech>
Cc: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_upgrade --check fails to warn about abstime
Date: 2023-09-20 17:58:07
Message-ID: 202309201758.vox63zqcqpi4@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2023-Sep-20, Tristan Partin wrote:

> > +/*
> > + * check_for_removed_data_type_usage
> > + *
> > + * similar to the above, but for types that were removed in 12.
> > + */
> > +static void
> > +check_for_removed_data_type_usage(ClusterInfo *cluster, const char *datatype)
>
> Seems like you could make this more generic instead of hardcoding version
> 12, and then you could use it for any future removed types as well.

Yeah, I thought about that, and then closed that with "we can whack it
around when we need it". At this point I imagine there's very few other
datatypes we can remove from the core server, if any.

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"La libertad es como el dinero; el que no la sabe emplear la pierde" (Alvarez)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2023-09-20 17:59:28 Re: dikkop seems unhappy because of openssl stuff (FreeBSD 14-BETA1)
Previous Message Tristan Partin 2023-09-20 17:45:36 Re: pg_upgrade --check fails to warn about abstime