Re: Avoid a possible null pointer (src/backend/utils/adt/pg_locale.c)

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: michael(at)paquier(dot)xyz
Cc: pgsql(at)j-davis(dot)com, ranier(dot)vf(at)gmail(dot)com, robertmhaas(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Avoid a possible null pointer (src/backend/utils/adt/pg_locale.c)
Date: 2023-09-13 00:59:22
Message-ID: 20230913.095922.1595919735304121486.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Tue, 12 Sep 2023 09:03:27 +0900, Michael Paquier <michael(at)paquier(dot)xyz> wrote in
> On Mon, Sep 11, 2023 at 12:15:49PM -0700, Jeff Davis wrote:
> > That's fine with me.
>
> Okay. Then, please find attached a v4 for HEAD and REL_16_STABLE.

For example, they result in the following message:

ERROR: unsupported collprovider (pg_strcoll): i

Even if it is an elog message, I believe we can make it clearer. The
pg_strcoll seems like a collation privier at first glance. Not sure
about others, though, I would spell it as the follows instead:

ERROR: unsupported collprovider in pg_strcoll: i
ERROR: unsupported collprovider in pg_strcoll(): i

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Erik Wienhold 2023-09-13 01:00:07 Re: JSON Path and GIN Questions
Previous Message Imseih (AWS), Sami 2023-09-13 00:48:48 Jumble the CALL command in pg_stat_statements