Re: psql help message contains excessive indentations

From: Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: psql help message contains excessive indentations
Date: 2023-09-07 12:56:51
Message-ID: 20230907215651.066c74f56db904e3c9a1a23e@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 7 Sep 2023 13:06:35 +0200
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:

> On 2023-Sep-07, Yugo NAGATA wrote:
>
> > Yes. So, I mean how about fixing \watch description as the attached patch.
>
> > diff --git a/src/bin/psql/help.c b/src/bin/psql/help.c
> > index 38c165a627..12280c0e54 100644
> > --- a/src/bin/psql/help.c
> > +++ b/src/bin/psql/help.c
> > @@ -200,9 +200,9 @@ slashUsage(unsigned short int pager)
> > HELP0(" \\gset [PREFIX] execute query and store result in psql variables\n");
> > HELP0(" \\gx [(OPTIONS)] [FILE] as \\g, but forces expanded output mode\n");
> > HELP0(" \\q quit psql\n");
> > - HELP0(" \\watch [[i=]SEC] [c=N] [m=MIN]\n");
> > - HELP0(" execute query every SEC seconds, up to N times\n");
> > - HELP0(" stop if less than MIN rows are returned\n");
> > + HELP0(" \\watch [[i=]SEC] [c=N] [m=MIN]\n"
> > + " execute query every SEC seconds, up to N times\n"
> > + " stop if less than MIN rows are returned\n");
>
> Yeah, this looks right to me -- the whole help entry as a single
> translatable unit, instead of three separately translatable lines.

Thank you for your explanation. I understood it. I thought of just
imitating other places, and I didn't know each is a single translatable
unit.

Regards,
Yugo Nagata

> --
> Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
> "Estoy de acuerdo contigo en que la verdad absoluta no existe...
> El problema es que la mentira sí existe y tu estás mintiendo" (G. Lama)

--
Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2023-09-07 13:11:45 Re: persist logical slots to disk during shutdown checkpoint
Previous Message Hayato Kuroda (Fujitsu) 2023-09-07 12:24:23 RE: [PoC] pg_upgrade: allow to upgrade publisher node