Re: Inefficiency in parallel pg_restore with many tables

On Sun, Sep 03, 2023 at 12:04:00PM +0200, Alvaro Herrera wrote:
> On 2023-Sep-02, Nathan Bossart wrote:
>> I ended up hacking together a (nowhere near committable) patch to see how
>> hard it would be to allow using any type with binaryheap. It doesn't seem
>> too bad.
>
> Yeah, using void * seems to lead to interfaces that are pretty much the
> same as bsearch() or qsort().

Right. This is what I had in mind.

> (Why isn't your payload type const,
> though?)

It probably should be const. This patch was just a proof-of-concept and
still requireѕ a bit of work.

> I do wonder why did you change _remove_first and _first to have a
> 'result' output argument instead of a return value. Does this change
> actually buy you anything? simplehash.h doesn't do that either.
>
>> -extern void binaryheap_add(binaryheap *heap, Datum d);
>> -extern Datum binaryheap_first(binaryheap *heap);
>> -extern Datum binaryheap_remove_first(binaryheap *heap);
>> -extern void binaryheap_replace_first(binaryheap *heap, Datum d);
>> +extern void binaryheap_add(binaryheap *heap, void *d);
>> +extern void binaryheap_first(binaryheap *heap, void *result);
>> +extern void binaryheap_remove_first(binaryheap *heap, void *result);
>> +extern void binaryheap_replace_first(binaryheap *heap, void *d);

_first could likely just return a pointer to the data in the binary heap's
array. However, _remove_first has to copy the data somewhere, so I think
the alternative would be to return a palloc'd value. Is there another way
that I'm not thinking of?

--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com