From: | Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> |
---|---|
To: | vik(at)postgresfriends(dot)org, jchampion(at)timescale(dot)com |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Row pattern recognition |
Date: | 2023-09-02 06:52:35 |
Message-ID: | 20230902.155235.1032214204265330340.t-ishii@sranhm.sra.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Attached is the v5 patch. Differences from previous patch include:
* Resolve complaint from "PostgreSQL Patch Tester"
https://commitfest.postgresql.org/44/4460/
- Change gram.y to use PATTERN_P instead of PATTERN. Using PATTERN seems
to make trouble with Visual Studio build.
:
:
[10:07:57.853] FAILED: src/backend/parser/parser.a.p/meson-generated_.._gram.c.obj
[10:07:57.853] "cl" "-Isrc\backend\parser\parser.a.p" "-Isrc\backend\parser" "-I..\src\backend\parser" "-Isrc\include" "-I..\src\include" "-Ic:\openssl\1.1\include" "-I..\src\include\port\win32" "-I..\src\include\port\win32_msvc" "/MDd" "/nologo" "/showIncludes" "/utf-8" "/W2" "/Od" "/Zi" "/DWIN32" "/DWINDOWS" "/D__WINDOWS__" "/D__WIN32__" "/D_CRT_SECURE_NO_DEPRECATE" "/D_CRT_NONSTDC_NO_DEPRECATE" "/wd4018" "/wd4244" "/wd4273" "/wd4101" "/wd4102" "/wd4090" "/wd4267" "-DBUILDING_DLL" "/Fdsrc\backend\parser\parser.a.p\meson-generated_.._gram.c.pdb" /Fosrc/backend/parser/parser.a.p/meson-generated_.._gram.c.obj "/c" src/backend/parser/gram.c
[10:07:57.860] c:\cirrus\build\src\backend\parser\gram.h(379): error C2365: 'PATTERN': redefinition; previous definition was 'typedef'
[10:07:57.860] C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\wingdi.h(1375): note: see declaration of 'PATTERN'
[10:07:57.860] c:\cirrus\build\src\backend\parser\gram.h(379): error C2086: 'yytokentype PATTERN': redefinition
[10:07:57.860] c:\cirrus\build\src\backend\parser\gram.h(379): note: see declaration of 'PATTERN'
[10:07:57.860] ninja: build stopped: subcommand failed.
* Resolve complaint from "make headerscheck"
- Change Windowapi.h and nodeWindowAgg.c to remove unecessary extern
and public functions.
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
Attachment | Content-Type | Size |
---|---|---|
v5-0001-Row-pattern-recognition-patch-for-raw-parser.patch | text/x-patch | 20.7 KB |
v5-0002-Row-pattern-recognition-patch-parse-analysis.patch | text/x-patch | 11.6 KB |
v5-0003-Row-pattern-recognition-patch-planner.patch | text/x-patch | 4.8 KB |
v5-0004-Row-pattern-recognition-patch-executor.patch | text/x-patch | 29.6 KB |
v5-0005-Row-pattern-recognition-patch-docs.patch | text/x-patch | 8.2 KB |
v5-0006-Row-pattern-recognition-patch-tests.patch | text/x-patch | 26.8 KB |
v5-0007-Allow-to-print-raw-parse-tree.patch | text/x-patch | 748 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | John Naylor | 2023-09-02 10:37:50 | Re: generate syscache info automatically |
Previous Message | Amit Kapila | 2023-09-02 04:38:51 | Impact of checkpointer during pg_upgrade |