From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
---|---|
To: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: GenBKI emits useless open;close for catalogs without rows |
Date: | 2023-09-01 17:43:30 |
Message-ID: | 20230901174330.6jbe4izkew4nlt7k@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2023-Sep-01, Matthias van de Meent wrote:
> A potential addition to the patch would to stop manually closing
> relations: initdb and check-world succeed without manual 'close'
> operations because the 'open' command auto-closes the previous open
> relation (in boot_openrel). Testing also suggests that the last opened
> relation apparently doesn't need closing - check-world succeeds
> without issues (incl. with TAP enabled). That is therefore implemented
> in attached patch 2 - it removes the 'close' syntax in its entirety.
Hmm, what happens with the last relation in the bootstrap process? Is
closerel() called via some other path for that one?
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
Essentially, you're proposing Kevlar shoes as a solution for the problem
that you want to walk around carrying a loaded gun aimed at your foot.
(Tom Lane)
From | Date | Subject | |
---|---|---|---|
Next Message | Matthias van de Meent | 2023-09-01 17:50:27 | Re: GenBKI emits useless open;close for catalogs without rows |
Previous Message | Tom Lane | 2023-09-01 17:41:41 | Re: Inefficiency in parallel pg_restore with many tables |