Re: Format list of catalog files in makefile vertically

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Format list of catalog files in makefile vertically
Date: 2023-08-26 16:38:15
Message-ID: 20230826163815.bont3h5uvdcqgo6q@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2023-Aug-25, Peter Eisentraut wrote:

> I propose to reformat the catalog lists in src/backend/catalog/Makefile to
> be more vertical, one per line. This makes it easier to keep that list in
> sync with src/include/catalog/meson.build, and visually compare both lists.
> Also, it's easier to read and edit in general.

+1

> In passing, I'd also copy over some relevant comments from the makefile to
> meson.build. For the hypothetical future when we delete the makefiles,
> these comments seem worth keeping. (For fun, I tested whether the comments
> are still true, and yes, the order still matters.)

Sure.

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"La experiencia nos dice que el hombre peló millones de veces las patatas,
pero era forzoso admitir la posibilidad de que en un caso entre millones,
las patatas pelarían al hombre" (Ijon Tichy)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2023-08-26 17:02:02 Re: [PATCH] Add XMLText function (SQL/XML X038)
Previous Message Anil 2023-08-26 16:15:10 Fwd: Invitation to Test and Contribute to Pgperffarm