| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Brown <michael(dot)brown(at)discourse(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: should frontend tools use syncfs() ? |
| Date: | 2023-08-22 17:11:10 |
| Message-ID: | 20230822171110.GA711171@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 22, 2023 at 12:53:53PM +0900, Michael Paquier wrote:
> On Mon, Aug 21, 2023 at 07:06:32PM -0700, Nathan Bossart wrote:
>> This would look something like the attached patch. I think this is nicer.
>> With this patch, we don't have to choose between including fd.h or
>> redefining the macros in the frontend code.
>
> Yes, this one is moving the needle in the good direction. +1.
Great. Here is a new patch set that includes this change as well as the
suggested documentation updates.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-move-PG_TEMP_FILE-macros-to-file_utils.h.patch | text/x-diff | 4.1 KB |
| v5-0002-allow-syncfs-in-frontend-utilities.patch | text/x-diff | 39.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2023-08-22 17:25:29 | Re: pgsql: Allow tailoring of ICU locales with custom rules |
| Previous Message | Jacob Champion | 2023-08-22 16:58:18 | Re: DecodeInterval fixes |