| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>, davecramer(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, peter(at)eisentraut(dot)org, robertmhaas(at)gmail(dot)com, smithpb2250(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Using defines for protocol characters |
| Date: | 2023-08-16 19:29:56 |
| Message-ID: | 20230816192956.GA2908487@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 15, 2023 at 11:40:07PM +0200, Alvaro Herrera wrote:
> On 2023-Aug-16, Michael Paquier wrote:
>
>> On Wed, Aug 16, 2023 at 06:25:09AM +0900, Tatsuo Ishii wrote:
>> > Currently pqcomm.h needs c.h which is not problem for Pgpool-II. But
>> > what about other middleware?
>>
>> Why do you need to include directly c.h? There are definitions in
>> there that are not intended to be exposed.
>
> What this argument says is that these new defines should be in a
> separate file, not in pqcomm.h. IMO that makes sense, precisely because
> these defines should be usable by third parties.
I moved the definitions out to a separate file in v6.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Introduce-macros-for-protocol-characters.patch | text/x-diff | 52.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonathan S. Katz | 2023-08-16 19:48:59 | PostgreSQL 16 RC1 + GA release dates |
| Previous Message | Michail Nikolaev | 2023-08-16 19:29:10 | Re: Replace known_assigned_xids_lck by memory barrier |