Re: [PATCH] Support % wildcard in extension upgrade filenames

From: Sandro Santilli <strk(at)kbt(dot)io>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Mat Arye <mat(at)timescaledb(dot)com>, Regina Obe <lr(at)pcorp(dot)us>, Yurii Rashkovskii <yrashk(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Regina Obe <r(at)pcorp(dot)us>
Subject: Re: [PATCH] Support % wildcard in extension upgrade filenames
Date: 2023-08-07 13:55:32
Message-ID: 20230807135532.r73nul3ksqr55rbk@c19
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 01, 2023 at 08:24:15PM +0200, Daniel Gustafsson wrote:
> > On 28 Jun 2023, at 10:29, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> >
> >> On 31 May 2023, at 21:07, Sandro Santilli <strk(at)kbt(dot)io> wrote:
> >> On Thu, Apr 27, 2023 at 12:49:57PM +0200, Sandro Santilli wrote:
> >
> >>> I'm happy to bring back the control-file switch if there's an
> >>> agreement about that.
> >>
> >> I'm attaching an up-to-date version of the patch with the control-file
> >> switch back in, so there's an explicit choice by extension developers.
> >
> > This version fails the extension test since the comment from the .sql file is
> > missing from test_extensions.out. Can you fix that in a rebase such that the
> > CFBot can have a green build of this patch?
>
> With no update to the thread and the patch still not applying I'm marking this
> returned with feedback. Please feel free to resubmit to a future CF when there
> is a new version of the patch.

Updated version of the patch is attached, regresses cleanly.
Will try to submit this to future CF from the website, let me know
if I'm doing it wrong.

--strk;

Attachment Content-Type Size
v4-0001-Allow-wildcard-in-extension-upgrade-paths.patch text/x-diff 10.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Pyhalov 2023-08-07 14:02:39 postgres_fdw could support row comparison pushdown
Previous Message Tom Lane 2023-08-07 13:29:29 Re: initial pruning in parallel append