| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Paul Guo <guopa(at)vmware(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Brown <michael(dot)brown(at)discourse(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: should frontend tools use syncfs() ? |
| Date: | 2023-07-29 21:40:10 |
| Message-ID: | 20230729214010.GA189456@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 13, 2022 at 06:54:12AM -0500, Justin Pryzby wrote:
> I didn't pursue this patch, as it's easier for me to use /bin/sync -f. Someone
> should adopt it if interested.
I was about to start a new thread, but I found this one with some good
preliminary discussion. I came to the same conclusion about introducing a
new option instead of using syncfs() by default wherever it is available.
The attached patch is still a work-in-progress, but it seems to behave as
expected. I began investigating this because I noticed that the
sync-data-directory step on pg_upgrade takes quite a while when there are
many files, and I am looking for ways to reduce the amount of downtime
required for pg_upgrade.
The attached patch adds a new --sync-method option to the relevant frontend
utilities, but I am not wedded to that name/approach.
Thoughts?
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-allow-syncfs-in-frontend-utilities.patch | text/x-diff | 15.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2023-07-29 21:51:24 | Postmaster doesn't correctly handle crashes in PM_STARTUP state |
| Previous Message | Nathan Bossart | 2023-07-29 21:14:18 | Re: add timing information to pg_upgrade |