| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Gurjeet Singh <gurjeet(at)singh(dot)im> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Richard Veselý <richard(dot)vesely(at)softea(dot)sk>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Fwd: BUG #18016: REINDEX TABLE failure |
| Date: | 2023-07-27 23:10:59 |
| Message-ID: | 20230727231059.GA3612597@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Wed, Jul 26, 2023 at 06:42:14PM -0700, Gurjeet Singh wrote:
> On Wed, Jul 26, 2023 at 10:50 AM Nathan Bossart
> <nathandbossart(at)gmail(dot)com> wrote:
>> On Mon, Jul 10, 2023 at 09:35:05AM -0700, Gurjeet Singh wrote:
>> > The code block movement involved slightly more thought and care than I
>> > had previously imagined. As explained in comments in the patch, the
>> > enumeration and suppression of indexes on the main table must happen
>> > before any CommandCounterIncrement() call, hence the
>> > reindex-the-toast-table-if-any code had to be placed after that
>> > enumeration.
>>
>> Do we need to add another CCI after reindexing the TOAST table? It looks
>> like we presently do so between reindexing each relation, including the
>> TOAST table.
>
> Yes, we do need to do a CCI after reindex the relation's toast table.
> But note that it is done by the recursive call to reindex_relation(),
> right after it calls reindex_index().
*facepalm*
Ah, I see it now.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2023-07-27 23:14:41 | Re: Fwd: BUG #18016: REINDEX TABLE failure |
| Previous Message | PG Bug reporting form | 2023-07-27 21:05:31 | BUG #18040: PostgreSQL does not report its version correctly |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2023-07-27 23:14:41 | Re: Fwd: BUG #18016: REINDEX TABLE failure |
| Previous Message | Michael Paquier | 2023-07-27 22:42:07 | Re: Removing the fixed-size buffer restriction in hba.c |