Re: Inefficiency in parallel pg_restore with many tables

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Inefficiency in parallel pg_restore with many tables
Date: 2023-07-25 18:53:36
Message-ID: 20230725185336.GA2911441@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 24, 2023 at 12:00:15PM -0700, Nathan Bossart wrote:
> Here is a sketch of this approach. It required fewer #ifdefs than I was
> expecting. At the moment, this one seems like the winner to me.

Here is a polished patch set for this approach. I've also added a 0004
that replaces the open-coded heap in pg_dump_sort.c with a binaryheap.
IMHO these patches are in decent shape.

--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v6-0001-Make-binaryheap-available-to-frontend-code.patch text/x-diff 8.5 KB
v6-0002-Add-function-for-removing-arbitrary-nodes-in-bina.patch text/x-diff 2.6 KB
v6-0003-Convert-pg_restore-s-ready_list-to-a-priority-que.patch text/x-diff 15.7 KB
v6-0004-Remove-open-coded-binary-heap-in-pg_dump_sort.c.patch text/x-diff 6.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2023-07-25 18:59:23 Re: cataloguing NOT NULL constraints
Previous Message Isaac Morland 2023-07-25 17:32:56 Re: cataloguing NOT NULL constraints