| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Inefficiency in parallel pg_restore with many tables |
| Date: | 2023-07-24 19:00:15 |
| Message-ID: | 20230724190015.GA2528613@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jul 22, 2023 at 10:57:03PM -0700, Nathan Bossart wrote:
> On Sat, Jul 22, 2023 at 07:47:50PM -0400, Tom Lane wrote:
>> I wonder whether we can't provide some alternate definition or "skin"
>> for binaryheap that preserves the Datum API for backend code that wants
>> that, while providing a void *-based API for frontend code to use.
>
> I can give this a try next, but it might be rather #ifdef-heavy.
Here is a sketch of this approach. It required fewer #ifdefs than I was
expecting. At the moment, this one seems like the winner to me.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-make-binaryheap-available-to-frontend.patch | text/x-diff | 7.5 KB |
| v5-0002-expand-binaryheap-api.patch | text/x-diff | 2.1 KB |
| v5-0003-use-priority-queue-for-pg_restore-ready_list.patch | text/x-diff | 14.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2023-07-24 19:05:39 | Re: cataloguing NOT NULL constraints |
| Previous Message | Peter Geoghegan | 2023-07-24 18:59:32 | Re: Use of additional index columns in rows filtering |