Re: pgsql: Integrate pg_bsd_indent into our build/test infrastructure.

Hi,

On 2023-02-12 17:22:27 +0000, Tom Lane wrote:
> Integrate pg_bsd_indent into our build/test infrastructure.
...
> src/tools/pg_bsd_indent/t/001_pg_bsd_indent.pl | 53 ++++++++++++++++++++++

I just saw a random failure of exactly one of the test in CI (when testing a
new meson version, oddly enough):

# Running: diff -upd C:/cirrus/src/tools/pg_bsd_indent/tests/elsecomment.0.stdout elsecomment.out
[21:41:17.438](0.076s) not ok 13 - pg_bsd_indent output matches for elsecomment
[21:41:17.438](0.000s) # Failed test 'pg_bsd_indent output matches for elsecomment'
# at C:/cirrus/src/tools/pg_bsd_indent/t/001_pg_bsd_indent.pl line 50.

And subsequently noticed that CI currently doesn't collect the tests.diff
file, so I don't know why that failed. CI currently collects all *.diffs
files, I don't really want it to also collect all .diff files, since most of
the time that would be redundant with the .diffs file.

Would you mind if I rename the output file to test.diffs? That seems to make
more sense than explicitly capturing this file...

Greetings,

Andres Freund