Re: Autogenerate some wait events code and documentation

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Andres Freund <andres(at)anarazel(dot)de>, "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Autogenerate some wait events code and documentation
Date: 2023-07-10 07:11:36
Message-ID: 20230710071136.jiedze443q7o5vsp@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2023-Jul-09, Michael Paquier wrote:

> Patch 0002 introduces a set of simplifications for the format of
> wait_event_names.txt:
> - Removal of the first column for the enums.

I don't like this bit, because it means the .txt file is now ungreppable
as source of the enum name. Things become mysterious and people have to
track down the event name by reading the the Perl generating script.
It's annoying. I'd rather have the extra column, even if it means a
little duplicity.

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"Siempre hay que alimentar a los dioses, aunque la tierra esté seca" (Orual)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2023-07-10 07:23:58 Re: Schema variables - new implementation for Postgres 15
Previous Message Peter Smith 2023-07-10 07:08:31 Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication