Re: vacuumdb/clusterdb/reindexdb: allow specifying objects to process in all databases

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: vacuumdb/clusterdb/reindexdb: allow specifying objects to process in all databases
Date: 2023-06-30 05:13:32
Message-ID: 20230630051332.GB2640352@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 30, 2023 at 12:05:17PM +0900, Kyotaro Horiguchi wrote:
> At Thu, 29 Jun 2023 13:56:38 -0700, Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote in
>> Sorry, I'm not following. I intentionally avoided allowing combinations of
>> --schema and --table in the patches I sent. This is the current behavior
>> of vacuumdb. Are you suggesting that they should be treated as restriction
>> filters?
>
> No. I'm not suggesting. Just saying that they would look appear to
> work as a restriction filters if those two options can be specified at
> once.

Got it, thanks for clarifying.

>> Perhaps we could add something like a --skip-missing option.
>
> But isn't it a bit too complicated for the gain?
>
> I don't have a strong objection if we're fine with just allowing
> "--all --schema=xxx", knowing that it will works cleanly only for
> system catalogs.

Okay. I haven't scoped out what would be required to support a
--skip-missing option, but it doesn't sound too terribly complicated to me.

--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Drouvot, Bertrand 2023-06-30 05:55:51 Re: Synchronizing slots from primary to standby
Previous Message Nathan Bossart 2023-06-30 05:09:21 Re: pgsql: Fix search_path to a safe value during maintenance operations.