| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Joe Conway <mail(at)joeconway(dot)com> |
| Subject: | Re: Clean up JumbleQuery() from query text |
| Date: | 2023-06-26 15:51:17 |
| Message-ID: | 20230626155117.GA1279020@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 26, 2023 at 05:44:49PM +0900, Michael Paquier wrote:
> Joe has reported me offlist that JumbleQuery() includes a dependency
> to the query text, but we don't use that anymore as the query ID is
> generated from the Query structure instead.
>
> Any thoughts about the cleanup attached? But at the same time, this
> is simple and a new thing, so I'd rather clean up that now rather than
> later.
LGTM
> It is not urgent, so I am fine to postpone that after beta2 is
> released on 17~ if there are any objections to that, of course.
Even if extensions are using it, GA for v16 is still a few months away, so
IMO it's okay to apply it to v16.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kirk Wolak | 2023-06-26 16:59:21 | Re: pgbnech: allow to cancel queries during benchmark |
| Previous Message | Andrew Dunstan | 2023-06-26 15:48:26 | Re: function arguments are not PG_FUNCTION_ARGS, how to pass Node *escontext |