Re: Consistent coding for the naming of LR workers

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: smithpb2250(at)gmail(dot)com
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Consistent coding for the naming of LR workers
Date: 2023-06-16 01:43:27
Message-ID: 20230616.104327.1878440413098623268.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Thu, 15 Jun 2023 12:42:33 +1000, Peter Smith <smithpb2250(at)gmail(dot)com> wrote in
> It is better to have a *single* point where these worker names are
> defined, so then all output uses identical LR worker nomenclature.
>
> PSA a small patch to modify the code accordingly. This is not intended
> to be a functional change - just a code cleanup.
>
> Thoughts?

I generally like this direction when it actually decreases the number
of translatable messages without making grepping on the tree
excessively difficult. However, in this case, the patch doesn't seems
to reduce the translatable messages; instead, it makes grepping
difficult.

Addition to that, I'm inclined to concur with Alvaro regarding the
gramattical aspect.

Consequently, I'd prefer to leave these alone.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2023-06-16 02:07:42 Re: Non-superuser subscription owners
Previous Message Masahiko Sawada 2023-06-16 01:38:19 Re: subscription/033_run_as_table_owner is not listed in the meson.build