Re: win32ver data in meson-built postgres.exe

From: Noah Misch <noah(at)leadboat(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>, Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: win32ver data in meson-built postgres.exe
Date: 2023-06-09 20:14:55
Message-ID: 20230609201455.GB1431998@rfd.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 08, 2023 at 01:10:00PM +0200, Magnus Hagander wrote:
> On Thu, Jun 8, 2023 at 3:45 AM Noah Misch <noah(at)leadboat(dot)com> wrote:
> > On Wed, Jun 07, 2023 at 04:47:26PM -0700, Andres Freund wrote:
> > > On 2023-06-07 16:14:07 -0700, Noah Misch wrote:
> > > > postgres.exe is icon-free.
> > >
> > > We could also just change that.
> >
> > I would be +1 for that (only if done for all build systems). Showing the
> > elephant in task manager feels better than showing the generic-exe icon.
>
> I think this decision goes back all the way to the ancient times, and
> the argument was then "user should not use the postgres.exe file when
> clicking around" sort of. Back then, task manager didn't show the icon
> at all, regardless. It does now, so I'm +1 to add the icon (in all the
> build systems).

That sounds good, and it's the attached one-byte change. That also simplifies
the Meson fix; new version attached.

Attachment Content-Type Size
icon-postgres.exe-v1.patch text/plain 947 bytes
win32ver-backend-meson-v2.patch text/plain 1.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2023-06-09 20:54:09 pgsql: Fix search_path to a safe value during maintenance operations.
Previous Message Peter Geoghegan 2023-06-09 19:23:36 Re: Cleaning up nbtree after logical decoding on standby work