Re: v16 fails to build w/ Visual Studio 2015

On Wed, Jun 07, 2023 at 11:34:09PM +0200, Peter Eisentraut wrote:
> On 07.06.23 23:21, Andres Freund wrote:
> >On 2023-06-07 11:54:58 -0700, Noah Misch wrote:
> >>Visual Studio 2015 version "14.0.25431.01 Update 3" has an apparent compiler
> >>bug that causes the build to fail with "readfuncs.switch.c(522): fatal error
> >>C1026: parser stack overflow, program too complex (compiling source file
> >>src/backend/nodes/readfuncs.c)". While I wouldn't mind revoking support for
> >>Visual Studio 2015, changing the code to cope is easy. See attached.
> >
> >I don't see a point in trying to keep Visual Studio 2015 working. We have no
> >automated testing for it, as evidenced by this issue. It seems quite possible
> >we're going to hit such issues in other places.
>
> Apparently, nobody has used it between Sat Jul 9 08:52:19 2022 and now?

Essentially. I assume you're referring to commit 964d01a "Automatically
generate node support functions". I bet it actually broke a few days later,
at ff33a8c "Remove artificial restrictions on which node types have out/read
funcs."