Re: could not extend file "base/5/3501" with FileFallocate(): Interrupted system call

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Christoph Berg <myon(at)debian(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: could not extend file "base/5/3501" with FileFallocate(): Interrupted system call
Date: 2023-06-06 19:53:00
Message-ID: 20230606195300.wackhn5qc7nic5l5@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2023-Apr-24, Andres Freund wrote:

> A prototype of that approach is attached. I pushed the retry handling into the
> pg_* routines where applicable. I guess we could add pg_* routines for
> FileFallocate(), FilePrewarm() etc as well, but I didn't do that here.
>
> Christoph, could you verify this fixes your issue?

So, is anyone making progress on this? I don't see anything in the
thread.

On adding the missing pg_* wrappers: I think if we don't (and we leave
the retry loops at the File* layer), then the risk is that some external
code would add calls to the underlying File* routines trusting them to
do the retrying, which would then become broken when we move the retry
loops to the pg_* wrappers when we add them. That doesn't seem terribly
serious to me.

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"El Maquinismo fue proscrito so pena de cosquilleo hasta la muerte"
(Ijon Tichy en Viajes, Stanislaw Lem)

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2023-06-07 04:02:54 pgsql: Reload configuration more frequently in apply worker.
Previous Message Heikki Linnakangas 2023-06-06 17:57:31 pgsql: Initialize 'recordXtime' to silence compiler warning.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-06-06 19:55:45 Re: Order changes in PG16 since ICU introduction
Previous Message Robert Haas 2023-06-06 19:37:17 Re: Order changes in PG16 since ICU introduction