Re: SyncRepWaitForLSN waits for XLogFlush?

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tejasvi Kashi <mail(at)tejasvi(dot)dev>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: SyncRepWaitForLSN waits for XLogFlush?
Date: 2023-05-24 21:33:10
Message-ID: 20230524213310.b2j7nnvcrt7a7wxx@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2023-05-24 10:53:51 -0400, Tejasvi Kashi wrote:
> I was wondering if waiting for an LSN in SyncRepWaitForLSN ensures that the
> XLOG has been flushed locally up to that location before the record is
> shipped off to standbys?

No, SyncRepWaitForLSN() doesn't directly ensure that. The callers have to (and
do) call XLogFlush() separately. See e.g. the XLogFlush() call in
RecordTransactionCommit().

Note that calling SyncRepWaitForLSN() for an LSN that is not yet flushed would
not lead for data to be prematurely sent out - walsender won't send data that
hasn't yet been flushed. So a backend with such a spurious SyncRepWaitForLSN()
would just wait until the LSN is actually flushed and *then* replicated.

Any specific reason for that question?

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-05-24 21:35:52 Re: testing dist tarballs
Previous Message Tom Lane 2023-05-24 21:28:30 Re: Wrong results due to missing quals