Re: pgsql: Move snowball_create.sql creation into perl file

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Christoph Berg <myon(at)debian(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, PostgreSQL Packagers <pgsql-packagers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Move snowball_create.sql creation into perl file
Date: 2023-05-23 18:41:57
Message-ID: 20230523184157.ao4ytkwqxkgp3glk@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Hi,

On 2023-05-23 10:46:30 -0400, Tom Lane wrote:
> Christoph Berg <myon(at)debian(dot)org> writes:
> >> this seems to have broken out-of-tree builds from tarballs:
> >>
> >> /usr/bin/install -c -m 644 snowball_create.sql '/srv/projects/postgresql/debian/16/build/tmp_install/usr/share/postgresql/16'
> >> /usr/bin/install: cannot stat 'snowball_create.sql': No such file or directory
>
> I think the attached will do for a proper fix.

Thanks.

> I'm not inclined to re-wrap just for this.

Agreed.

I wonder if we should add a CI task to test creating a tarball and building
from it, both inside the source directory and as a vpath build? We rebuild for
both gcc and clang, each with assertions and without, to check if there are
warnings. We could probably just switch to building from the tarball for some
of those.

I guess I need to go and check how long the "release" tarball generation
takes...

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2023-05-23 18:51:03 Re: pgsql: Move snowball_create.sql creation into perl file
Previous Message Tom Lane 2023-05-23 15:16:10 pgsql: Fix the install rule for snowball_create.sql.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-05-23 18:48:54 Re: ERROR: no relation entry for relid 6
Previous Message Tom Lane 2023-05-23 18:33:27 Re: memory leak in trigger handling (since PG12)