| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Xing Guo <higuoxing(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: PL/Python: Fix return in the middle of PG_TRY() block. |
| Date: | 2023-05-04 04:54:13 |
| Message-ID: | 20230504045413.GA2202617@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 03, 2023 at 01:58:38PM -0700, Nathan Bossart wrote:
> With this change, pltdata isn't modified in the PG_TRY section, and the
> only modification of pltargs happens after all elogs. It might be worth
> keeping pltargs volatile in case someone decides to add an elog() in the
> future, but I see no need to keep it for pltdata.
Here's a new patch that removes the volatile marker from pltdata.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Fix-improper-returns-in-PG_TRY-blocks.patch | text/x-diff | 3.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2023-05-04 05:01:08 | Re: PL/Python: Fix return in the middle of PG_TRY() block. |
| Previous Message | Amit Kapila | 2023-05-04 04:43:17 | Re: Add two missing tests in 035_standby_logical_decoding.pl |