Re: Support logical replication of DDLs

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>
Cc: shveta malik <shveta(dot)malik(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, "Wei Wang (Fujitsu)" <wangw(dot)fnst(at)fujitsu(dot)com>, Runqi Tian <runqidev(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, li jie <ggysxcq(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Japin Li <japinli(at)hotmail(dot)com>, rajesh singarapu <rajesh(dot)rs0541(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Zheng Li <zhengli10(at)gmail(dot)com>
Subject: Re: Support logical replication of DDLs
Date: 2023-05-03 09:04:53
Message-ID: 20230503090453.df22u4mukrvcnxx6@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Patch 0001 adds a new event trigger type that can be fired, but it's
missing documentation and its own tests. (I think part of the docs are
in 0002, but that seems to be only the changes to the supported
operations table, without any other explanation for it in sect1
event-trigger-definition, and examples showing it at work). Adding a
new event trigger type is quite a major thing because it's user visible,
so a commit that adds that should be self-contained. Users will want to
use it for other things as soon as it's in, for reasons other than what
you're adding it for. This also means that you'll want to keep other
things separate, such as adding AlterTableStmt->table_like and the move
of structs from event_trigger.c to event_trigger.h ... and is
EventTriggerAlterTypeStart/End necessary in 0001 as well, or should it
be separate?

(I find patch series as single .tar.gz not very friendly. I think
compression is okay, but perhaps compress each patch separately.)

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/

In response to

Browse pgsql-general by date

  From Date Subject
Next Message Michael J. Baars 2023-05-03 11:11:36 Re: libpq and multi-threading
Previous Message Ron 2023-05-03 07:34:14 Re: Can one user login in multile machine?

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2023-05-03 10:03:57 Re: Add PQsendSyncMessage() to libpq
Previous Message John Naylor 2023-05-03 07:30:13 Re: [PATCH] Clarify the behavior of the system when approaching XID wraparound