| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add two missing tests in 035_standby_logical_decoding.pl |
| Date: | 2023-04-26 10:27:51 |
| Message-ID: | 20230426102751.pkfs7gwvvrgta6p3@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> diff --git a/src/test/perl/PostgreSQL/Test/Cluster.pm b/src/test/perl/PostgreSQL/Test/Cluster.pm
> index 6f7f4e5de4..819667d42a 100644
> --- a/src/test/perl/PostgreSQL/Test/Cluster.pm
> +++ b/src/test/perl/PostgreSQL/Test/Cluster.pm
> @@ -2644,7 +2644,16 @@ sub wait_for_catchup
> }
> if (!defined($target_lsn))
> {
> - $target_lsn = $self->lsn('write');
> + my $isrecovery = $self->safe_psql('postgres', "SELECT pg_is_in_recovery()");
> + chomp($isrecovery);
> + if ($isrecovery eq 't')
> + {
> + $target_lsn = $self->lsn('replay');
> + }
> + else
> + {
> + $target_lsn = $self->lsn('write');
> + }
Please modify the function's documentation to account for this code change.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"Porque Kim no hacía nada, pero, eso sí,
con extraordinario éxito" ("Kim", Kipling)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou (Fujitsu) | 2023-04-26 10:41:22 | RE: Perform streaming logical transactions by background workers and parallel apply |
| Previous Message | Jakub Wartak | 2023-04-26 10:18:39 | Re: Doc limitation update proposal: include out-of-line OID usage per TOAST-ed columns |