| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | sawada(dot)mshk(at)gmail(dot)com |
| Cc: | amit(dot)kapila16(at)gmail(dot)com, houzj(dot)fnst(at)fujitsu(dot)com, wangw(dot)fnst(at)fujitsu(dot)com, smithpb2250(at)gmail(dot)com, shiy(dot)fnst(at)fujitsu(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org, dilipbalaut(at)gmail(dot)com |
| Subject: | Re: Perform streaming logical transactions by background workers and parallel apply |
| Date: | 2023-04-24 02:55:46 |
| Message-ID: | 20230424.115546.1307338856880653904.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Mon, 24 Apr 2023 11:50:37 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> I concur that returning false is problematic.
>
> For assertion builds, Assert typically provides more detailed
> information than elog. However, in this case, it wouldn't matter much
> since the worker would repeatedly restart even after a server-restart
> for the same reason unless cosmic rays are involved. Moreover, the
> situation doesn't justify server-restaring, as it would unnecessarily
> involve other backends.
Please disregard this part, as it's not relavant to non-assertion builds.
> In my opinion, it is fine to replace the Assert with an ERROR.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shaurya jain | 2023-04-24 02:59:44 | Re: Logical replication failed with SSL SYSCALL error |
| Previous Message | Kyotaro Horiguchi | 2023-04-24 02:50:37 | Re: Perform streaming logical transactions by background workers and parallel apply |