| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Jeff Davis <pgsql(at)j-davis(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, fabriziomello(at)gmail(dot)com, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Rahila Syed <rahila(dot)syed(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Minimal logical decoding on standbys |
| Date: | 2023-04-11 20:10:57 |
| Message-ID: | 20230411201057.qsjw7pjgtpvxcvn2@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2023-04-11 11:04:50 +0200, Drouvot, Bertrand wrote:
> On 4/11/23 10:55 AM, Drouvot, Bertrand wrote:
> > Hi,
> >
> > I think we might want to add:
> >
> > $node_primary->wait_for_replay_catchup($node_standby);
> >
> > before calling the slot creation.
> >
> > It's done in the attached, would it be possible to give it a try please?
>
> Actually, let's also wait for the cascading standby to catchup too, like done in the attached.
Pushed. Seems like a clear race in the test, so I didn't think it was worth
waiting for testing it on hoverfly.
I think we should lower the log level, but perhaps wait for a few more cycles
in case there are random failures?
I wonder if we should make the connections in poll_query_until to reduce
verbosity - it's pretty annoying how much that can bloat the log. Perhaps also
introduce some backoff? It's really annoying to have to trawl through all
those logs when there's a problem.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2023-04-11 20:13:49 | infobits_set WAL record struct field is int8 |
| Previous Message | Tom Lane | 2023-04-11 20:03:37 | Re: [PATCH] Use role name "system_user" instead of "user" for unsafe_tests |