Re: pgsql: Try to unbreak MSVC builds for pg_waldump

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Geoghegan <pg(at)bowt(dot)ie>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Try to unbreak MSVC builds for pg_waldump
Date: 2023-04-08 18:13:35
Message-ID: 20230408181335.c5ny27ydofu3c5ez@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi,

On 2023-04-08 13:53:34 -0400, Tom Lane wrote:
> Peter Geoghegan <pg(at)bowt(dot)ie> writes:
> > I was under the impression that issues like this would be caught by
> > CI. We used to have an MSVC CI target, but that's no longer the case
> > -- not since commit e6b6ea02. I'll need to remember that.
>
> I thought we were planning to drop the MSVC build scripts for v16.
> Is that no longer happening? If they're going to be around for
> awhile, maybe that CI job needs to be resurrected.

I was holding off submitting a patch until the BF supported meson - which only
happened recently. I was actually planning to start a thread about the topic
in the next few days.

As far as I can tell, the meson build has more than feature parity with the
"homegrown" build - the only two dependencies I haven't been able to test is
building with are ossp-uuid (doesn't build) and kerberos (quite complicated,
last release for windows is ages ago)

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2023-04-08 19:32:02 Re: pgsql: Try to unbreak MSVC builds for pg_waldump
Previous Message Peter Geoghegan 2023-04-08 18:06:54 Re: pgsql: Try to unbreak MSVC builds for pg_waldump